Victorgiannakouris/ch648/support open at for arrays #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
requested changes
Nov 21, 2019
Member
Shelnutt2
left a comment
Shelnutt2
left a comment
There was a problem hiding this comment.
Let's add a second Array constructor which can open encrypted arrays with a timestamp also.
Can you add new unit tests for both new constructors?
Member
|
Also you need to format the files with |
Shelnutt2
approved these changes
Dec 13, 2019
Shelnutt2
deleted the
victorgiannakouris/ch648/support-open-at-for-arrays
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clubhouse Link
https://app.clubhouse.io/tiledb-inc/story/648/support-open-at-for-arrays
Story ID
648
Description
This PR contains the implementation of the time-travelling feature in Java API.