Replace getCoordinates with setBuffer #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
requested changes
May 19, 2020
| try (Domain domain = schema.getDomain(); | ||
| NativeArray domainArray = | ||
| new NativeArray(ctx, 2 * (int) domain.getRank(), domain.getType())) { | ||
| new NativeArray( |
There was a problem hiding this comment.
This is not right, you don't need domain.rank() here. If the second parameter is "elements" then just 2 is enough.
| try (Domain domain = schema.getDomain(); | ||
| NativeArray domainArray = | ||
| new NativeArray(ctx, 2 * (int) domain.getRank(), domain.getType())) { | ||
| new NativeArray(ctx, 2 * (int) domain.getRank(), domain.getDimension(name).getType())) { |
gsvic
force-pushed
the
victorgiannakouris/remove_get_coords
branch
2 times, most recently
from
a8da75b to
829f016
Compare
gsvic
force-pushed
the
victorgiannakouris/remove_get_coords
branch
from
829f016 to
dd1aa61
Compare
Shelnutt2
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
getCoordinateswithsetBufferfor dimensions