manylinux2010 based build for native artifacts #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pursuing a manylinux2010 based build the openssl library lookups were failing when building cURL; likely because of misuse of the `--with-ssl` configure flag. As currently structured the configure generated cURL Makefile does not correctly add multilib paths to the linker search paths due to pkgconfig metadata not being used. Specifying `with-ssl` with a path creates this scenario. If openssl can find multilib [1] directories during the configure phase of the build it will use them. Currently, via cmake in this repository, TileDB will be built in such a way that openssl will be built after the `lib64` multilib directory has been created. TileDB-Py, which also uses a manylinux2010 build, has these same structural problems but includes Azure support by default. This changes the external dependency build order, openssl comes up first, the `lib64` directoriy is missing `LIBDIR` is set to `lib` and the rest of the build completes successfully. Not wanting to hack on the TileDB build itself the easiest solution was to add Azure support to TileDB-Java. It also has the nice side effect of including the support. 1. https://github.com/openssl/openssl/blob/OpenSSL_1_1_0h/Configurations/unix-Makefile.tmpl#L147-L155
This reverts commit 53a38ea.
Shelnutt2
reviewed
Sep 16, 2020
Shelnutt2
approved these changes
Sep 17, 2020
gsvic
approved these changes
Sep 17, 2020
|
@chris-allan thanks for the PR! We'll rebase #192 on this and then cut a new release for you to test out. |
|
Working off the snapshot [1] currently deployed by the build of |
|
Fix for the above issue (I think) proposed as #195. |
|
Looking good: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #191 which sets a much earlier lowest common denominator that matches TileDB-Py.