Update SWIG generation for TileDB#3306 CAPIHandle changes #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `-I ${prefix_dir}/include` so that internal includes can be found
- add `-x c++-header` to silence warning
```
warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated
```
- add `|| true` to some rm calls so they don't fail if the output has
previously been removed
- x-ref TileDB-Inc/TileDB#3306
Contributor
DimitrisStaratzis
left a comment
DimitrisStaratzis
left a comment
There was a problem hiding this comment.
Thanks for the PR. The suggested changes work as expected but they fail to generate the FILTER constants . I am working on a fix.
Due to SWIG limitations it appears that we need to add swig typedefs for any tiledb_*_handle_t typedef using the new CAPIHandle infrastructure.
Member
Author
|
TileDB-Inc/TileDB#3414 moves a non-TileDB |
DimitrisStaratzis
approved these changes
Aug 23, 2022
Contributor
DimitrisStaratzis
left a comment
DimitrisStaratzis
left a comment
There was a problem hiding this comment.
Works as expected. Thank you! I will merge when 2.12.0 is out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
-I ${prefix_dir}/includeso that internal includes can be foundadd
-x c++-headerto silence warningadd
|| trueto some rm calls so they don't fail if the output haspreviously been removed
x-ref
class CAPIHandleand start of C API restructuring TileDB#3306