Skip to content

Conversation

@DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Jul 25, 2023

There is no need to run the entire submit method and populate the buffers when writing. This was the case before this proposed change. This will save memory when writing to arrays

@DimitrisStaratzis DimitrisStaratzis marked this pull request as draft July 25, 2023 18:05
@DimitrisStaratzis DimitrisStaratzis marked this pull request as ready for review August 3, 2023 08:10
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DimitrisStaratzis DimitrisStaratzis merged commit 2af746e into master Aug 4, 2023
@DimitrisStaratzis DimitrisStaratzis deleted the dstara/memory_improvements branch August 4, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants