Skip to content

Update CI macos fall back value #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mojaveazure merged 2 commits into from
Sep 23, 2025
Merged

Update CI macos fall back value #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb528d6
Update CI macos R version fallback value
cgiachalis Sep 23, 2025
ee6b587
code-review
cgiachalis Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/r-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ARCH=$(uname -m)

# Default CRAN repo (use the CDN) and R verssion
CRAN=${CRAN:-"https://cloud.r-project.org"}
RVER=${RVER:-"4.4.1"}
RVER=${RVER:-"4.5.1"}

## Optional drat repos, unset by default
DRAT_REPOS=${DRAT_REPOS:-""}
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,22 @@ env:
jobs:
ci:
strategy:
fail-fast: false
matrix:
include:
- {os: macOS-latest}
- {os: ubuntu-latest}
- {os: macOS-latest, r: '4.5.1' }
- {os: ubuntu-latest, r: 'release'}
Copy link
Copy Markdown
Collaborator

@jdblischak jdblischak Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly confusing since RVER has no effect on the Ubuntu builds. For example, someone might try changing it to '4.5.0' or 'devel', and would be surprised that this had no effect. I assume you did this in order to inject the R version in to the name below. I'm not strongly opposed to this strategy, but I wonder if there is an alternative mechanism.

Copy link
Copy Markdown
Contributor Author

@cgiachalis cgiachalis Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you did this in order to inject the R version in to the name below.

Exactly.


runs-on: ${{ matrix.os }}
name: ${{ matrix.os }} (${{ matrix.r }})

steps:
- uses: actions/checkout@v4

- name: System
run: sysctl -a
run: |
sysctl -a
echo "RVER=${{ matrix.r}}" >> $GITHUB_ENV
if: ${{ matrix.os == 'macOS-latest' }}

- name: Bootstrap
Expand Down
Loading