FilterPipeline::run_reverse offsets tile is const, and some other tweaks#5768
Merged
Conversation
rroelke
commented
Mar 3, 2026
|
|
||
| /** Returns the opened array. */ | ||
| inline const shared_ptr<OpenedArray> opened_array() const { | ||
| inline const shared_ptr<OpenedArray>& opened_array() const { |
Contributor
Author
There was a problem hiding this comment.
This was a strange one. The Rust #[cxx::bridge] expanded C++ code does not handle the return type of const std::shared_ptr<T> even though this should be equivalent to a return of std::shared_ptr<T>.
shaunrd0
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #5766 , this is useful for declaring Rust bindings to these methods, since Rust is much stricter about mutability.
TYPE: NO_HISTORY
DESC:
FilterPipeline::run_reverseoffsets tile isconst