feat: add proxy configuration file to Helm chart#66
Merged
Tim-herbie merged 1 commit intoTim-herbie:mainfrom Apr 2, 2026
Merged
feat: add proxy configuration file to Helm chart#66Tim-herbie merged 1 commit intoTim-herbie:mainfrom
Tim-herbie merged 1 commit intoTim-herbie:mainfrom
Conversation
HttpRafa
commented
Apr 1, 2026
| - name: config-files | ||
| configMap: | ||
| name: {{ include "opencloud.opencloud.fullname" . }}-config | ||
| - name: proxy-config |
Author
There was a problem hiding this comment.
I removed this because it is not used anywhere
There was a problem hiding this comment.
Pull request overview
Adds support for a proxy.yaml configuration file in the OpenCloud Helm chart so proxy-related settings (e.g., role mappings / quotas) can be supplied via values or default templates and mounted into the OpenCloud container.
Changes:
- Add
opencloud.config.proxytovalues.yaml(with a commented example). - Render
proxy.yamlinto the existing OpenCloud ConfigMap and mount it into the deployment. - Introduce a default
files/opencloud/proxy.yaml.gotmpltemplate.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| charts/opencloud/values.yaml | Adds opencloud.config.proxy values entry and documentation/example. |
| charts/opencloud/templates/opencloud/deployment.yaml | Mounts /etc/opencloud/proxy.yaml from the shared config files ConfigMap. |
| charts/opencloud/templates/opencloud/configmap.yaml | Adds proxy.yaml key to the main OpenCloud ConfigMap, rendered from values or a template. |
| charts/opencloud/files/opencloud/proxy.yaml.gotmpl | Adds the default proxy configuration template content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Seems good, thank you! |
Author
|
@Tim-herbie When do you plan to release the next release? |
Owner
|
@HttpRafa Right now ;) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
proxy.yamlfile to the chart. This file can be used to specify role mappings between an Identity Provider (e.g., Authentik) and OpenCloud roles, such as Admin, User, or SpaceAdmin (see Automatic Role Assignments). Additionally, it makes it possible to add default quotas to roles. See Default User Quota.Credits: > This implementation is based on and closely mirrors the work originally done by XA21X in this commit.