iPad Support#9
Merged
TimCinel merged 6 commits intoTimCinel:masterfrom Jul 20, 2011
johnnyg:master
Merged
Conversation
…is no longer off screen
This also fixes an object leak when cancelling the action picker
The view is now also sent to the action selector Note: UIPopoverController was used as ActionSheet doesn't support UIPickerView on the iPad
Owner
|
Wow, I really appreciate that you've done this. Unfortunately my only computer with OS X has been away getting fixed, so I'm unable to merge it. It's meant to be back next week - this will be the first thing I do when I get it. Sorry for the delay! |
Contributor
|
This works brilliantly @johnnyg ... great work!!! |
Owner
|
Finally got the computer back. Great work, thanks for sharing :) |
Contributor
Author
|
No worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Tim,
I've added iPad support for ActionSheetPicker.
Despite its name, this was actually done with a UIPopoverController as I think it's not possible to have a UIPickerView inside an UIActionSheet on the iPad (or at least I was unable to do so successfully).
I've also made a few other fixes.
I should mention that this was tested with XCode 4 using the 4.3 SDK for both iPhone & iPad.
Cheers,
Johnny.
P.S. I wasn't able to get the Sample iPad version to have the same stripy background, not sure what gives there...