Merged
Conversation
Ensures truth and query tsv files use the same column names in each report. That enables easier downstream data processing.
While ERRTYPE is used in most variable names, ERR_TYPE is used only in this document and in the truth.tsv file. This change centers all references to this variable around the ERRTYPE name.
Owner
|
Thanks for the contribution! Sorry, didn't notice this PR when you initially opened it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Another minor bug (v. minor?) fix. Right now, query.tsv output files use the column header ERR_TYPE for the tsv column containing TP/FP/FN annotations, and truth.tsv files use ERRTYPE. That makes downstream analysis difficult, since you have to change that column name if you want to merge these two datasets in any way.
ERR_TYPE is only used when writing query.tsv or in the Outputs.md wiki page. All other references to those data (variable names, etc) use ERRTYPE. So, this pull request changes those two instances of "ERR_TYPE" to ERRTYPE, unifying the naming conventions and easing downstream analysis.
Hope this is helpful,
Joe