Update setup_minecraft_lxc.sh#72
Merged
TimInTech merged 1 commit intoTimInTech:mainfrom May 1, 2026
Merged
Conversation
Fix error in jq LATEST_VERSION=
Contributor
Author
|
Suggested change per |
Owner
|
Thanks for the fix – the root cause is correct, One concern with the current approach: LATEST_VERSION=$(curl -fsSL -H "User-Agent: ${USER_AGENT}" "${FILL_API}" | jq -r '.versions | keys | last')Could you update the PR accordingly? |
TimInTech
added a commit
that referenced
this pull request
May 1, 2026
The Fill v3 API returns .versions as an object, not an array. `keys | last` yields the lexicographically highest (= newest) version reliably. Same fix as applied to setup_minecraft_lxc.sh in PR #72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error in jq LATEST_VERSION=
Pull Request – Simulation Only
Summary
Describe what this PR changes (scripts, docs). No commands are executed in this workspace.
Checklist
SIMULATION.mdupdated to reflect behavior and risks.Testing (Simulation)
Explain expected side effects if run on a proper host (files created, services started, ports opened). Include rollback/cleanup notes.