fix: use .text to handle empty project titles in user.loves() (#581)#588
Open
SyedAhris wants to merge 2 commits intoTimMcCool:mainfrom
Open
fix: use .text to handle empty project titles in user.loves() (#581)#588SyedAhris wants to merge 2 commits intoTimMcCool:mainfrom
SyedAhris wants to merge 2 commits intoTimMcCool:mainfrom
Conversation
Collaborator
|
Hello. how are you? |
Author
|
Hi, Im great what about you? |
Collaborator
|
I was just thinking about my oven. I really need to use it tbh. |
Author
|
Okayy? Sure? Idk what you mean? Its my first time trying open source contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581
The issue happens because .contents[0] throws an IndexError when a project has no title. Switching to .text returns an empty string instead, which handles that case cleanly.