Made filter recreation happen in each layout pass#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found in testing when rapidly cycling between light and dark mode that the blur effect would break.
It appears that the blur effect gets reset back to its opaque block upon trait changes. Even though I reapplied the effect in the trait collection callback, it appeared to be happening too early.
So it might have made the library slightly less performant, but I made it that the filter is always updated in each layout pass, and then set
setNeedsLayoutin the trait changes. I then audited all of the call sites to make sure we weren't callinglayoutSubviewsmultiple times unnecessarily.Seems to be working correctly now in all of my tests