Skip to content

Conversation

@TimUx
Copy link
Owner

@TimUx TimUx commented Nov 17, 2025

Summary

  • expose UI lock flags in the state API so wishes block show buttons and running shows block all actions
  • render the wish queue on the home page with labels for the current and waiting songs, plus matching styles
  • document the queue display and button lock behaviour in the README

Testing

  • python -m py_compile app.py

Codex Task

@chatgpt-codex-connector
Copy link

💡 Codex Review

https://github.com/TimUx/fpp-control/blob/c38e1ce7ea550d995d74d660a4006e3b608c68d6/requests.html#L93-L96
P1 Badge Block wish submission while show is running

On the wishes page the status poll detects a running show but the disable flag computed in fetchState is never applied to the UI or request submission, so the list remains clickable even during playback. Submitting a wish while a show is running will post to /api/requests, which immediately stops the current playlist (start_request_song calls stop_effects_and_blackout) and interrupts the show despite the intended lock that “running shows block all actions.”

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@TimUx TimUx merged commit 159446c into main Nov 17, 2025
@TimUx TimUx deleted the codex/research-falcon-player-api-and-endpoints-grm1ug branch November 17, 2025 21:22
@TimUx TimUx restored the codex/research-falcon-player-api-and-endpoints-grm1ug branch November 18, 2025 10:31
@TimUx TimUx deleted the codex/research-falcon-player-api-and-endpoints-grm1ug branch November 20, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants