Skip to content

Conversation

@TimUx
Copy link
Owner

@TimUx TimUx commented Nov 17, 2025

Summary

  • arrange the home action buttons in a two-column grid for consistent spacing and shape

Testing

  • python -m py_compile app.py

Codex Task

@TimUx TimUx merged commit 8d3a516 into main Nov 17, 2025
@TimUx TimUx deleted the codex/research-falcon-player-api-and-endpoints-bd0q8h branch November 17, 2025 22:04
@chatgpt-codex-connector
Copy link

💡 Codex Review

https://github.com/TimUx/fpp-control/blob/1848276ee3175e0bfc513637172d2b50960055d3/index.html#L283-L286
P1 Badge Rotating access code never re-locks previously unlocked clients

The access gate only checks whether localStorage contains the hardcoded value 'yes', so once a browser has been unlocked it stays unlocked forever. If the operator changes ACCESS_CODE (e.g., from 1234 to 5678), existing clients with the old flag still bypass the prompt because hasAccess() ignores the new code and calls unlock() immediately. That makes code rotation ineffective and leaves the controls open to anyone who has ever entered any past code.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants