chore: docs/config/test accuracy sweep#99
Merged
Conversation
Audit (3 agents) of tests + docs + config vs the current code (post #96/#97/#98). Findings + fixes: Tests (suite was already healthy — no stale tests to delete): - Drop duplicate test_session.py::TestActiveSessions::test_set_and_clear (covered by test_session_dm.py create+delete); keep the empty-initial guard. - Strengthen 3 'is None or != AskUserQuestion' poach-guards to 'is None' (verified the parser returns None for those degraded-capture panes). Docs: - architecture.md: fix 'background sessions render their own cards' (they emit none — panel only); correct commands/ inventory (no /list /use /rename; add /health /help); add missing modules (logging_setup, metrics, voice_install, local_terminal, card_model, kb_mode, response_builder, context_poll [disabled], callbacks/help). - dm-architecture.md: rewrite the slash-command block to match setMyCommands reality (published: menu/help/history/done + forwarded CC pickers; hidden: new/kill/stop/archive/screenshot/usage/health). - dm-multisession-spec.md: BOT_TOKEN -> TELEGRAM_BOT_TOKEN, CLAUDE_BIN -> CLAUDE_COMMAND, MODEL_PATH -> WHISPER_MODEL_PATH; /history is published; flag /restore-file as not-yet-implemented. - dm-multisession-plan.md: banner marking it COMPLETED & SUPERSEDED (its file:line hotspot map targets the removed monolithic bot.py). Config: - .env.example: remove dead SESSION_TOKEN_BUDGET_5H / MAX_5H_TOKENS / MAX_WEEKLY_TOKENS (retired local token aggregator); document CCBOT_RESUME_SETTLE_TIMEOUT / CARD_EDIT_LAG / BG_STATUS_MAX / BG_STATUS_QUOTA_THRESHOLDS / LOG_LEVEL + a supervisor-knobs pointer. - session.py: stale '/status' -> 'Menu -> Status' in a comment. No behavior change (only a comment edit in src). 560 tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three read-only audit agents swept the tests, documentation, and config/env surfaces for drift against the current code (post #96/#97/#98). This PR applies the corrections.
Tests — suite was already healthy
The audit found no stale tests to delete (nothing tests retired features; the suite is green because dead paths were removed, not shimmed). Two minor cleanups:
tests/ccbot/test_session.py::TestActiveSessions::test_set_and_clear_active_session(the create→set→clear round-trip is covered bytest_session_dm.pycreate + delete). Kept the unique empty-initial-state guard.assert result is None or result.name != "AskUserQuestion"toassert result is None(verified the parser returnsNonefor those degraded-capture panes).Docs
commands/inventory (no/list /use /rename; added/health /help); added the modules that were missing from the inventory (logging_setup,metrics,voice_install,local_terminal,card_model,kb_mode,response_builder,context_poll[present-but-disabled],callbacks/help).setMyCommandsreality — published:menu/help/history/done(+ forwardedmodel/effort/compact/memory); hidden/typed:new/kill/stop/archive/screenshot/usage/health./list /use /renamenever existed.BOT_TOKEN→TELEGRAM_BOT_TOKEN,CLAUDE_BIN→CLAUDE_COMMAND,MODEL_PATH→WHISPER_MODEL_PATH;/historyis published; flagged/restore-fileas not-yet-implemented.file:linehotspot map targets the removed monolithicbot.py.Config
SESSION_TOKEN_BUDGET_5H/MAX_5H_TOKENS/MAX_WEEKLY_TOKENS(the retired local token aggregator — never read by code); documentedCCBOT_RESUME_SETTLE_TIMEOUT,CARD_EDIT_LAG,BG_STATUS_MAX,BG_STATUS_QUOTA_THRESHOLDS,LOG_LEVEL, and added a supervisor-knobs pointer./status→Menu → Statusin a comment.Not done in this PR (flagged for a decision)
VOICE_BACKEND=openaiis unreachable:config.pycoerces any non-auto/whisper/apple/offvalue toauto, and the settings UI allowlist excludesopenai— yettranscribe.pyhas a live_openai_transcribepath + docs. Either addopenaito the allowlists or strip the dead code/docs. A behavior decision, left out of this doc/test sweep.~/.claude/CLAUDE.md, not in any tracked file — left untouched.No behavior change (only a comment edit in
src/). 560 tests pass · ruff clean · pyright 0 errors.🤖 Generated with Claude Code