fix: error message when scaling media & invalid media unloading previous#441
Merged
FelipeDefensor merged 2 commits intodevfrom Apr 25, 2026
Merged
fix: error message when scaling media & invalid media unloading previous#441FelipeDefensor merged 2 commits intodevfrom
FelipeDefensor merged 2 commits intodevfrom
Conversation
Collaborator
Author
|
Previous failure on CI was due to flaky test. Note: |
azfoo
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@azfoo, I am not entirely sure how the
wait_for_signalwrapper works, so take an extra careful look at this one.The callback triggered by the media duration being available was being called before
wait_for_signalwhen the wrapper resumed the event loop withloop.exec(). As the user takes some time to click the dialog, the wrapper ended up timing out and returningFalseas a success value, which triggered the error message.This also somehow takes care of the previous valid media being unloaded when invalid files tried to be loaded.
I didn't find a way to manually test this. The whole media load process is fragile, so I suggest we redo manual tests before releasing.
Closes #440.
Closes #425.