Skip to content

fix: error message when scaling media & invalid media unloading previous#441

Merged
FelipeDefensor merged 2 commits intodevfrom
fix-error-message-when-scaling
Apr 25, 2026
Merged

fix: error message when scaling media & invalid media unloading previous#441
FelipeDefensor merged 2 commits intodevfrom
fix-error-message-when-scaling

Conversation

@FelipeDefensor
Copy link
Copy Markdown
Collaborator

@FelipeDefensor FelipeDefensor commented Apr 20, 2026

@azfoo, I am not entirely sure how the wait_for_signal wrapper works, so take an extra careful look at this one.

The callback triggered by the media duration being available was being called before wait_for_signal when the wrapper resumed the event loop with loop.exec(). As the user takes some time to click the dialog, the wrapper ended up timing out and returning False as a success value, which triggered the error message.

This also somehow takes care of the previous valid media being unloaded when invalid files tried to be loaded.

I didn't find a way to manually test this. The whole media load process is fragile, so I suggest we redo manual tests before releasing.

Closes #440.
Closes #425.

@FelipeDefensor FelipeDefensor requested a review from azfoo April 20, 2026 17:35
@FelipeDefensor FelipeDefensor added this to the v0.6.0 milestone Apr 20, 2026
@FelipeDefensor
Copy link
Copy Markdown
Collaborator Author

Previous failure on CI was due to flaky test.

Note: git commit --allow-empty -m "empty" creates and empty commit that triggers CI.

@FelipeDefensor FelipeDefensor merged commit af000af into dev Apr 25, 2026
11 checks passed
@azfoo azfoo deleted the fix-error-message-when-scaling branch April 25, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants