Misc fixes

[azfoo]

29177d3 seems to resolve #428

[FelipeDefensor]

This is mostly approved. There is just one relevant bug for which I am working on a fix. Will push it tomorrow.

It would be good to address the comments, but it is not priority.

[FelipeDefensor]

I don't see why _check_timeline_height would return a bool if we didn't need to make this line work. This is conciser, but the following would be more readable, and do without the _check_timeline_height return value:

result = self.timeline.alter_levels(...)
self._check_timeline_height()
return result

[azfoo]

I don't see why _check_timeline_height would return a bool if we didn't need to make this line work. This is conciser, but the following would be more readable, and do without the _check_timeline_height return value:

result = self.timeline.alter_levels(...)
self._check_timeline_height()
return result

Because doing return a() and b() means that if a() returns False, b() doesn't run and False is returned. Still, happy to rewrite.

[FelipeDefensor]

Oh, that's true, but the performance gain from not evaluating b() is negligible in this case, right? In any case, we could still do:

result = self.timeline.alter_levels(...)
if result:
    self._check_timeline_height()
return result

[FelipeDefensor]

Same as above.

[FelipeDefensor]

This does more than check. A better name would be _adjust_timeline_height.

[FelipeDefensor]

Good to go from my part. Addressing the comments is optional. Review my changes before merging.

[FelipeDefensor]

The capital letter already indicated the default on your implementation. I forgot about that convention, sorry. At least we have the option of setting a default now.