fix: add PlanningEntity's comparatorClass and comparatorFactoryClass as bean defining annotation values in Quarkus

[Christopher-Chianelli]

Fixes #1951

[triceo]

This is very brittle; it's not reasonable to expect that people will remember to add every new field here as well. Case in point: I believe we also introduced the comparator on list variable.

Surely we can reflect over the annotations and detect those fields? These annotations are public API; any field we find is user-facing.

[Christopher-Chianelli]

This is very brittle; it's not reasonable to expect that people will remember to add every new field here as well. Case in point: I believe we also introduced the comparator on list variable.

Surely we can reflect over the annotations and detect those fields? These annotations are public API; any field we find is user-facing.

I have mixed feelings on this: in theory, we could add an annotation method that return a class that is not a bean, although we haven't yet. Additionally, when a new Annotation class is added, it still need to be added to DotNames (in particular, some annotations define member accessors, and others define planning entities; we cannot deduce that info from an annotation class).

[triceo]

I agree it is not perfect. Especially the fact that new annotations still need to be manually added. But IMO it is an improvement over status quo.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud