Skip to content

refactor: remove deprecations around score and constraints#2106

Merged
triceo merged 5 commits intoTimefoldAI:mainfrom
triceo:cs
Feb 13, 2026
Merged

refactor: remove deprecations around score and constraints#2106
triceo merged 5 commits intoTimefoldAI:mainfrom
triceo:cs

Conversation

@triceo
Copy link
Collaborator

@triceo triceo commented Feb 12, 2026

No description provided.

@triceo triceo requested a review from TomCools as a code owner February 12, 2026 15:18
Copilot AI review requested due to automatic review settings February 12, 2026 15:18
@triceo triceo mentioned this pull request Feb 12, 2026
Merged
@triceo triceo added this to the v2.0.0.CR1 milestone Feb 12, 2026
Copilot AI reviewed Feb 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@triceo triceo requested a review from Copilot February 12, 2026 19:47
Copilot AI reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

zepfred
zepfred reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request significantly cleans up and simplifies the API!

After reviewing all the changes, I've noticed that we are removing many migration recipes without including any new ones. This means that users will need to update everything manually. Is that the intended plan?

@triceo
Copy link
Collaborator Author

triceo commented Feb 13, 2026

I've noticed that we are removing many migration recipes without including any new ones. This means that users will need to update everything manually. Is that the intended plan?

The recipes need the final migrated state to compile; which is why they cannot exist for any of the things that I removed. (Which is pretty much all the things we had migration recipes for.)

I still need to write new recipes for many of the things I just did. It's on my list. But overall, the process of migration from 1.x will have to start by running all the old recipes while still on 1.x.

Copilot AI review requested due to automatic review settings February 13, 2026 08:42
Copilot AI reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 13, 2026

Quality Gate Passed Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.9% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud

@triceo triceo merged commit 83fa869 into TimefoldAI:main Feb 13, 2026
18 of 19 checks passed
@triceo triceo deleted the cs branch February 13, 2026 11:11
triceo added a commit to TimefoldAI/timefold-quickstarts that referenced this pull request Feb 13, 2026
@triceo
refactor: remove deprecations around score and constraints (#1020)
236c584 
Counterparts:
TimefoldAI/timefold-solver#2106
TimefoldAI/timefold-solver-enterprise#449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@zepfred zepfred zepfred approved these changes

@TomCools TomCools Awaiting requested review from TomCools TomCools is a code owner

@Christopher-Chianelli Christopher-Chianelli Awaiting requested review from Christopher-Chianelli Christopher-Chianelli is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0-beta-1

Development

Successfully merging this pull request may close these issues.

3 participants

@triceo @zepfred