Merged
Conversation
This commit migrates all column-related operations in enhanced_tui.rs to use the DataProvider trait instead of directly accessing JSON data. Changes: - calculate_column_statistics: Now uses DataProvider::get_row() to extract column data instead of directly accessing results.data JSON - sort_by_column: Uses DataProvider::get_column_names() for column names instead of extracting from JSON objects - calculate_optimal_column_widths: Uses DataProvider::get_column_widths() instead of passing raw JSON to ColumnManager - move_column_right: Uses DataProvider::get_column_count() to determine max columns instead of checking JSON object length - goto_last_column: Also uses DataProvider::get_column_count() This is part of the incremental migration strategy (V43) to decouple the TUI from the underlying data format, moving towards a clean DataTable/DataView architecture. All tests pass and the application remains fully functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.