Further columnar work#697
Merged
frankmcsherry merged 3 commits intoTimelyDataflow:master-nextfrom Mar 24, 2026
Merged
Conversation
frankmcsherry
force-pushed
the
further_columnar
branch
from
e05ab06 to
aec4298
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pressure tests the columnar example further by having it perform a reachability test, which now forces implementations of
Enter,Leave,Negate, andResultsIn, as well as a builder that works withpush()as required byreduce. There are unexercised by thespines.rsworkload, and .. we may want to update that as well.It also moves a lot of the support logic to
columnar_support.rs, with the intent of 1. continuing to exercise building this outside the "repo", and 2. making the work available to other example implementations to test.