add host name config#5
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines how the application determines its base URL by introducing a configurable Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a HOST_NAME configuration setting to use a static base URL, replacing dynamic URL detection. This simplifies the logic and improves consistency across the application. My main feedback is on the new HOST_NAME setting in app/core/config.py, which has a hardcoded default value. This could lead to misconfigurations in different environments. I've suggested making it a required environment variable by removing the default value for better robustness.
| AUTO_UPDATE_CATALOGS: bool = True | ||
| CATALOG_REFRESH_INTERVAL_SECONDS: int = 21600 # 6 hours | ||
| APP_ENV: Literal["development", "production"] = "development" | ||
| HOST_NAME: str = "https://1ccea4301587-watchly.baby-beamup.club" |
There was a problem hiding this comment.
Hardcoding a specific public URL as the default value for HOST_NAME is not recommended. This can lead to misconfigurations where development or other environments inadvertently use this URL. It's better to make this a required setting by removing the default value. This will force the value to be explicitly set in the environment, preventing accidental use of a wrong hostname. The .env.example file already guides the user to set this value.
| HOST_NAME: str = "https://1ccea4301587-watchly.baby-beamup.club" | |
| HOST_NAME: str |
No description provided.