Fix print version#52
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates SKM’s CLI version display so Go module build metadata can supply the installed version, addressing issue #48 where --help showed a stale static version.
Changes:
- Replaces direct
Versionusage with aversion()helper. - Defaults local/unset builds to
dev. - Uses build info for Go-installed versions and ldflags/default as fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cmd/skm/main.go |
Uses the new version helper for CLI app metadata. |
cmd/skm/logo.go |
Adds build-info version resolution and updates logo version rendering. |
Comments suppressed due to low confidence (1)
cmd/skm/logo.go:37
- The ldflags fallback returns Version without the same normalization applied to build-info versions. The existing GoReleaser config sets main.Version from {{.Tag}}, and the repository’s release tags/docs use a leading v, so release binaries that hit this fallback will render the logo as SKM Vv0.x.y because the logo format already prefixes V.
return Version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if info, ok := debug.ReadBuildInfo(); ok { | ||
| v := strings.TrimPrefix(info.Main.Version, "v") | ||
| // accept only real release tags, skip devel/dirty/pseudo-versions | ||
| if v != "" && v != "(devel)" && !strings.Contains(v, "+") && !strings.HasPrefix(v, "0.0.0-") { |
| ) | ||
|
|
||
| // version returns the go-install module tag, else the Version var (ldflags/default). | ||
| func version() string { |
Owner
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly self-explanatory
If skm is installed using
go installit would usedebug.ReadBuildInfo()to get an actual version.If other method - it would use
-ldflagIf no ldflag was set - it would use static "dev" instead of v0.8.1 as it was before.
Should fix #48