✨feat add optional-apps.json support and update docs/version#11
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThis pull request introduces optional app installation support via a secondary WinGet manifest, updates Windows 11 minimum support from 22H2 to 24H2 across documentation and presets, refactors bootstrap and ISO build scripts to handle the optional workflow with reusable abstractions, adds progress tracking to backup operations, and updates Sophia Script version references. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Bootstrap as bootstrap.ps1
participant Shortcut as Install Optional Apps.lnk
participant WinGet as WinGet
participant OptApps as optional-apps.json
User->>Bootstrap: Run bootstrap.ps1 (initial)
Bootstrap->>Bootstrap: Install core apps (apps.json)
Bootstrap->>Bootstrap: Complete main setup steps
opt optional-apps.json exists
Bootstrap->>Bootstrap: Create shortcut (Install Optional Apps.lnk)
Bootstrap->>User: Prompt: Install optional apps now? (Y/N)
alt User selects Yes
Bootstrap->>OptApps: Load optional-apps.json
Bootstrap->>WinGet: Import manifest
Bootstrap->>WinGet: Install packages
WinGet-->>Bootstrap: Installation result
Bootstrap->>Bootstrap: Record completion marker
else User selects No / Later
Bootstrap->>Bootstrap: Record no-install state
end
end
opt User clicks shortcut later
Shortcut->>Bootstrap: Invoke with -OptionalAppsOnly
Bootstrap->>OptApps: Load optional-apps.json
Bootstrap->>WinGet: Import manifest (skip core steps)
WinGet-->>Bootstrap: Installation result
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee6e0c7f24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elseif (-not (Test-Path $OptionalAppsJson)) { | ||
| Write-Log "optional-apps.json not found at $OptionalAppsJson - skipping optional apps shortcut" -Level INFO | ||
| Add-SummaryItem -Step "Optional Apps Shortcut" -Status "WARN" -Message "optional-apps.json not found" | ||
| Set-StepState -StepId $stepId -Status "done" -Message "optional-apps.json not found" |
There was a problem hiding this comment.
Leave optional shortcut step pending when manifest is absent
Setting optionalShortcut to done when optional-apps.json is missing prevents this step from ever running again in normal reruns, so adding optional-apps.json later will not create Install Optional Apps.lnk. This breaks the advertised “install later via shortcut” flow for users who create the optional manifest after the first bootstrap run unless they force-reset state.
Useful? React with 👍 / 👎.
Summary by CodeRabbit
New Features
System Requirements
Workflow & Improvements