Merged
Conversation
genesis.yml
Outdated
Comment on lines
+303
to
+306
| if NSClassFromString("XCTestCase") == nil { | ||
| registerProviderFactories() | ||
| appFlow.start() | ||
| } |
Contributor
There was a problem hiding this comment.
Thoughts on introducing an AppPlugin and moving this logic into it?
Contributor
Author
There was a problem hiding this comment.
I would have to see a demo of that working to be able to have an opinion on it.
Contributor
Author
There was a problem hiding this comment.
Thinking more about your question, I realized what you are suggesting is likely not even feasible since, I believe, registerProviderFactories() must be called before creating or using the plugin.
tinder-garricnahapetian
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.