Merged
Conversation
tinder-cfuller
requested review from
tinder-caiofonseca,
tinder-garricnahapetian and
tinder-matthewmourlam
tinder-caiofonseca
previously approved these changes
Jul 22, 2022
tinder-caiofonseca
approved these changes
Jul 22, 2022
tinder-caiofonseca
approved these changes
Jul 22, 2022
tinder-garricnahapetian
approved these changes
Jul 22, 2022
Comment on lines
+17
to
+21
| public struct Node { | ||
|
|
||
| public let name: String | ||
| public let children: [Node] | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add a public init? I'm seeing failures in https://github.com/TinderApp/tinder_ios/pull/34580 related to FlowMock: Flow in various tests with error: protocol requires property 'tree' with type 'Node'.
Contributor
Author
There was a problem hiding this comment.
Yes, that is an unfortunate oversight. I will make a PR 👍
Contributor
Author
There was a problem hiding this comment.
Or can be in the next one if it is not a blocker.
Contributor
There was a problem hiding this comment.
This is how I've dealt with it: https://github.com/TinderApp/tinder_ios/pull/34580/commits/cacc6f7d0a6905e2c3f203578216b74a274d9101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console Usage Example
When stopped at a breakpoint in a
Flow:When stopped at a breakpoint in a
Context:When stopped at a breakpoint in a
FlowController:Since
namewill be blank for anyFlowController, root can be skipped by performingpo tree.children.