Merged
Conversation
tinder-cfuller
requested review from
tinder-caiofonseca and
tinder-garricnahapetian
tinder-caiofonseca
approved these changes
Jul 26, 2022
tinder-garricnahapetian
approved these changes
Jul 26, 2022
Contributor
tinder-garricnahapetian
left a comment
tinder-garricnahapetian
left a comment
There was a problem hiding this comment.
I wonder if we should move these test helpers to a repo so that they become a dependency of the Quick Starts and Tinder. We can document them etc.
Contributor
Author
We may have discussed this previously. My preference would be that we contribute these to the open source Needle repository itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.