Skip to content

Add new Binding factory methods#186

Merged
seppesnoeck merged 18 commits intomainfrom
add-binding-extensions
Nov 2, 2022
Merged

Add new Binding factory methods#186
seppesnoeck merged 18 commits intomainfrom
add-binding-extensions

Conversation

@seppesnoeck
Copy link
Contributor

@seppesnoeck seppesnoeck commented Oct 14, 2022 •
edited
Loading

This PR will create two Binding extensions.

Created a new directory: Nodes > Sources > Nodes > SwiftUI
Created a new file Binding.Swift

@seppesnoeck seppesnoeck self-assigned this Oct 14, 2022
tinder-cfuller
tinder-cfuller reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ⭐

@tinder-cfuller tinder-cfuller mentioned this pull request Oct 14, 2022
Closed
tinder-cfuller
tinder-cfuller reviewed Oct 19, 2022
View reviewed changes
seppesnoeck and others added 2 commits October 20, 2022 14:18
@seppesnoeck @tinder-cfuller
Update documentation
f413226 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
@seppesnoeck @tinder-cfuller
Update documentation
e1bac4d 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-cfuller
tinder-cfuller approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ⭐

tinder-cfuller
tinder-cfuller reviewed Oct 20, 2022
View reviewed changes
tinder-cfuller
tinder-cfuller reviewed Oct 20, 2022
View reviewed changes
tinder-cfuller
tinder-cfuller reviewed Oct 20, 2022
View reviewed changes
tinder-cfuller
tinder-cfuller reviewed Oct 20, 2022
View reviewed changes
tinder-cfuller
tinder-cfuller previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tinder-cfuller tinder-cfuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want the capitalized Binding to be considered a type?

@seppesnoeck @tinder-cfuller
Update documentation title
0f652e8 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
seppesnoeck and others added 3 commits October 21, 2022 09:36
@seppesnoeck @tinder-cfuller
Update documentation title
55282c2 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
@seppesnoeck @tinder-cfuller
Update documentation title
d10dbd4 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
@seppesnoeck @tinder-cfuller
Update documentation title
a80e409 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-cfuller
tinder-cfuller previously approved these changes Oct 21, 2022
View reviewed changes
@tinder-cfuller
Copy link
Contributor

tinder-cfuller commented Oct 21, 2022

@seppesnoeck I think we should add tests as well.

tinder-cfuller
tinder-cfuller previously approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! ⭐

@seppesnoeck @tinder-cfuller
Test multiple types for both factories
ea3d271 
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-cfuller
tinder-cfuller approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ⭐

@seppesnoeck seppesnoeck merged commit d90a94b into main Nov 2, 2022
@seppesnoeck seppesnoeck deleted the add-binding-extensions branch November 2, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tinder-cfuller tinder-cfuller tinder-cfuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework Framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seppesnoeck @tinder-cfuller @tinder-garricnahapetian