Add MutableState Protocol#190
Merged
tinder-garricnahapetian merged 32 commits intomainfrom Mar 31, 2023
Merged
Conversation
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
May you please add DocC comments to the methods in both the protocol and the extension? And please add two unit tests as well. Thank you!
Contributor
tinder-garricnahapetian
left a comment
tinder-garricnahapetian
left a comment
There was a problem hiding this comment.
Please consider adding documentation.
Contributor
tinder-garricnahapetian
left a comment
tinder-garricnahapetian
left a comment
There was a problem hiding this comment.
Please consider adding tests.
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-garricnahapetian
requested review from
tinder-cfuller
and removed request for
tinder-cfuller
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Contributor
There was a problem hiding this comment.
@tinder-garricnahapetian One last thought, I believe we should consider the name applying instead of with for the non-mutating method. This would follow Apple's naming guidelines I believe.
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-garricnahapetian
requested review from
tinder-cfuller and
tinder-garricnahapetian
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add a new MutableState Protocol.