Skip to content

Add isViewInjectedNodeEnabled property to Config #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinder-garricnahapetian merged 1 commit into from
Nov 19, 2022
Merged

Add isViewInjectedNodeEnabled property to Config #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/XcodeTemplateGeneratorLibrary/Config.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ extension XcodeTemplates {
}

public var uiFrameworks: [UIFramework]
public var isViewInjectedNodeEnabled: Bool
public var includedTemplates: [String]
public var fileHeader: String
public var baseImports: Set<String>
Expand Down Expand Up @@ -113,6 +114,7 @@ extension XcodeTemplates.Config {
// swiftlint:disable:next function_body_length
public init() {
uiFrameworks = [UIFramework(framework: .uiKit), UIFramework(framework: .swiftUI)]
isViewInjectedNodeEnabled = true
includedTemplates = [
"Node",
"NodeSwiftUI",
Expand Down Expand Up @@ -211,6 +213,9 @@ extension XcodeTemplates.Config {
uiFrameworks =
(try? decoder.decode(CodingKeys.uiFrameworks))
?? defaults.uiFrameworks
isViewInjectedNodeEnabled =
(try? decoder.decode(CodingKeys.isViewInjectedNodeEnabled))
?? defaults.isViewInjectedNodeEnabled
includedTemplates =
(try? decoder.decode(CodingKeys.includedTemplates))
?? defaults.includedTemplates
Expand Down
1 change: 1 addition & 0 deletions Tests/XcodeTemplateGeneratorLibraryTests/ConfigTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ final class ConfigTests: XCTestCase {
viewControllerProperties: <viewControllerProperties-Custom>
viewControllerMethods: <viewControllerMethods-Custom>
viewControllerMethodsForRootNode: <viewControllerMethodsForRootNode-Custom>
isViewInjectedNodeEnabled: true
includedTemplates:
- includedTemplates-1
- includedTemplates-2
Expand Down
1 change: 1 addition & 0 deletions Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/ConfigTests/testConfig.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
▿ includedTemplates: 2 elements
- "includedTemplates-1"
- "includedTemplates-2"
- isViewInjectedNodeEnabled: true
- publisherFailureType: "publisherFailureType"
- publisherType: "publisherType"
- rootViewControllerMethods: "rootViewControllerMethods"
Expand Down
1 change: 1 addition & 0 deletions Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/ConfigTests/testDefaultConfig.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- "PluginNode"
- "Plugin"
- "Worker"
- isViewInjectedNodeEnabled: true
- publisherFailureType: ", Never"
- publisherType: "AnyPublisher"
- rootViewControllerMethods: "override func viewDidLoad() {\n super.viewDidLoad()\n view.backgroundColor = .systemBackground\n}\n\noverride func viewWillAppear(_ animated: Bool) {\n super.viewWillAppear(animated)\n observe(viewState).store(in: &cancellables)\n}\n\noverride func viewDidAppear(_ animated: Bool) {\n super.viewDidAppear(animated)\n receiver?.viewDidAppear()\n}\n\noverride func viewWillDisappear(_ animated: Bool) {\n super.viewWillDisappear(animated)\n cancellables.removeAll()\n}"
Expand Down
1 change: 1 addition & 0 deletions Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/ConfigTests/testEmptyConfig.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- "PluginNode"
- "Plugin"
- "Worker"
- isViewInjectedNodeEnabled: true
- publisherFailureType: ", Never"
- publisherType: "AnyPublisher"
- rootViewControllerMethods: "override func viewDidLoad() {\n super.viewDidLoad()\n view.backgroundColor = .systemBackground\n}\n\noverride func viewWillAppear(_ animated: Bool) {\n super.viewWillAppear(animated)\n observe(viewState).store(in: &cancellables)\n}\n\noverride func viewDidAppear(_ animated: Bool) {\n super.viewDidAppear(animated)\n receiver?.viewDidAppear()\n}\n\noverride func viewWillDisappear(_ animated: Bool) {\n super.viewWillDisappear(animated)\n cancellables.removeAll()\n}"
Expand Down