Use uiFramework(for kind:) in XcodeTemplates#212
Merged
tinder-garricnahapetian merged 3 commits intomainfrom Nov 22, 2022
Merged
Use uiFramework(for kind:) in XcodeTemplates#212tinder-garricnahapetian merged 3 commits intomainfrom
tinder-garricnahapetian merged 3 commits intomainfrom
Conversation
tinder-garricnahapetian
requested a review
from tinder-cfuller
as a code owner
tinder-caiofonseca
approved these changes
Nov 21, 2022
tinder-cfuller
approved these changes
Nov 22, 2022
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Please consider either adding tests for the other UIFramework kinds, or combine the two existing tests into a single test that loops through all the kinds.
Contributor
Author
I'm planning to add tests for all kinds in a subsequent PR. Trying to keep PRs as light as possible at each step. See each commit on this branch for more details: https://github.com/TinderApp/Nodes/tree/remaining-ui-framework-commits |
tinder-garricnahapetian
deleted the
use-ui-framework-for-kind-in-xcode-templates
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.