Closed
Conversation
seppesnoeck
changed the base branch from
main
to
remove-analytics-injection-viewcontroller
…o remove-analytics-injection-worker
…o remove-analytics-injection-viewcontroller
…ontroller' into remove-analytics-injection-worker
…ontroller' into remove-analytics-injection-worker
tinder-garricnahapetian
previously approved these changes
Dec 8, 2022
seppesnoeck
changed the title
Base automatically changed from
remove-analytics-injection-viewcontroller
to
main
March 6, 2023 09:04
# Conflicts: # Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/Builder-SwiftUI.stencil # Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/Builder.stencil # Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/ViewController-SwiftUI.stencil # Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/ViewController.stencil # Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/Worker.stencil # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNode.Analytics.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNode.Builder-AppKit.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNode.Builder-SwiftUI.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNode.ViewController-SwiftUI.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNode.Worker.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNodeRoot.Analytics.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNodeRoot.Builder-AppKit.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNodeRoot.Worker.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNodeSwiftUI.Analytics.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNodeSwiftUI.Worker.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/StencilRendererTests/testRenderNodeViewInjected.Worker.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithIdentifier.Contents-Developer-Xcode-Templates-File-Templates-Nodes-Architecture-Framework-identifier-Node-SwiftUI-xctemplate-___FILEBASENAME___Builder-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithIdentifier.Contents-Developer-Xcode-Templates-File-Templates-Nodes-Architecture-Framework-identifier-Node-SwiftUI-xctemplate-___FILEBASENAME___ViewController-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithIdentifier.Contents-Developer-Xcode-Templates-File-Templates-Nodes-Architecture-Framework-identifier-Node-SwiftUI-xctemplate-___FILEBASENAME___ViewStateWorker-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithIdentifier.Contents-Developer-Xcode-Templates-File-Templates-Nodes-Architecture-Framework-identifier-Node-UIKit-xctemplate-___FILEBASENAME___Builder-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithIdentifier.Contents-Developer-Xcode-Templates-File-Templates-Nodes-Architecture-Framework-identifier-Node-UIKit-xctemplate-___FILEBASENAME___ViewStateWorker-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithIdentifier.Contents-Developer-Xcode-Templates-File-Templates-Nodes-Architecture-Framework-identifier-Node-view-injected-xctemplate-___FILEBASENAME___Worker-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithURL.Contents-Node-SwiftUI-xctemplate-___FILEBASENAME___Builder-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithURL.Contents-Node-SwiftUI-xctemplate-___FILEBASENAME___ViewController-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithURL.Contents-Node-SwiftUI-xctemplate-___FILEBASENAME___ViewStateWorker-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithURL.Contents-Node-UIKit-xctemplate-___FILEBASENAME___Builder-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithURL.Contents-Node-UIKit-xctemplate-___FILEBASENAME___ViewStateWorker-swift.txt # Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/XcodeTemplatesTests/testGenerateWithURL.Contents-Node-view-injected-xctemplate-___FILEBASENAME___Worker-swift.txt
seppesnoeck
dismissed stale reviews from tinder-cfuller and tinder-garricnahapetian
via
41cba2a
tinder-cfuller
approved these changes
Mar 6, 2023
Contributor
Author
|
Work was done in #317. And is merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will remove the Analytics instance from the Worker.