Rename ViewControllable withModalStyle omitted argument parameter #250
Merged
tinder-matthewmourlam merged 1 commit intomainfrom Jan 27, 2023
Merged
Conversation
tinder-matthewmourlam
requested review from
seppesnoeck,
tinder-SamMarshall,
tinder-caiofonseca,
tinder-colecampbell and
tinder-garricnahapetian
tinder-matthewmourlam
requested a review
from tinder-cfuller
as a code owner
tinder-matthewmourlam
changed the title
ViewControllable withModalStyle omitted argument parameter ViewControllable withModalStyle omitted argument parameter
tinder-caiofonseca
approved these changes
Dec 15, 2022
tinder-matthewmourlam
changed the title
ViewControllable withModalStyle omitted argument parameter ViewControllable withModalStyle omitted argument parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
withModalStyleomitted argument parameter.func withModalStyle(_ style: ModalStyle) -> Self>func withModalStyle(_ modalStyle: ModalStyle) -> SelfNo other changes are required as omitted argument parameters are not required in protocol definition and conforming types are already using
modalStylefor parameter name.