Inject initialState into VC stencil and use viewState Publishers.Map#278
Merged
tinder-garricnahapetian merged 7 commits intomainfrom Dec 20, 2022
Merged
Conversation
tinder-garricnahapetian
requested a review
from tinder-cfuller
as a code owner
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Might it be preferred to have initialState come before viewState as in … "first here's the initial state, then here's how to get updated state"?
I also wonder if viewState should be named simply state or alternatively if initialState should be named initialViewState ?
Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/Builder.stencil
Outdated
Show resolved
Hide resolved
Contributor
Author
Sounds good. I'll move and use initialViewState. |
tinder-garricnahapetian
changed the title
Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/ViewController.stencil
Outdated
Show resolved
Hide resolved
tinder-cfuller
previously approved these changes
Dec 20, 2022
Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/ViewController.stencil
Outdated
Show resolved
Hide resolved
tinder-cfuller
previously approved these changes
Dec 20, 2022
Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/ViewController.stencil
Outdated
Show resolved
Hide resolved
tinder-garricnahapetian
requested review from
tinder-cfuller
and removed request for
tinder-cfuller
tinder-garricnahapetian
deleted the
inject-initial-state-into-vc-stencil
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.