Remove owns_view from Builder-SwiftUI.stencil as not needed#281
Merged
tinder-garricnahapetian merged 1 commit intomainfrom Dec 20, 2022
Merged
Remove owns_view from Builder-SwiftUI.stencil as not needed#281tinder-garricnahapetian merged 1 commit intomainfrom
tinder-garricnahapetian merged 1 commit intomainfrom
Conversation
tinder-garricnahapetian
requested a review
from tinder-cfuller
as a code owner
tinder-garricnahapetian
deleted the
remove-owns-view-where-not-needed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owns_view flag is never needed in
Builder-SwiftUI.stencilbecause bothNodeViewInjectedTemplateandStencilRenderer.renderNodeViewInjecteduseStencilTemplate.NodeViewInjected().stencilswhich hard codes its Builder stencil to.builder(.default). In other words, Nodes exposes zero public API for creating a view injected node with the Builder-SwiftUI stencil. Moreover, there should be zero logical reason to do so since the SwiftUI specific code in the Builder file is included only ifowns_viewis true and it would make zero sense to create a view injected node whereowns_viewis set to true.