Skip to content

Add viewDidLoad and update(with: initialState) to AppKit defaults #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinder-garricnahapetian merged 2 commits into from
Dec 21, 2022
Merged

Add viewDidLoad and update(with: initialState) to AppKit defaults #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cada145
Add viewDidLoad to AppKit defaults
tinder-garricnahapetian Dec 20, 2022
2a5e5ea
Merge branch 'main' into update-app-kit-defaults
tinder-garricnahapetian Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Sources/XcodeTemplateGeneratorLibrary/UIFramework/UIFramework+DefaultAppKit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ extension UIFramework {
private enum Defaults {

static let viewControllerMethods: String = """
override func viewDidLoad() {
super.viewDidLoad()
update(with: initialState)
}

override func viewWillAppear() {
super.viewWillAppear()
observe(statePublisher).store(in: &cancellables)
Expand All @@ -22,6 +27,11 @@ extension UIFramework {
"""

static let viewControllerMethodsForRootNode: String = """
override func viewDidLoad() {
super.viewDidLoad()
update(with: initialState)
}

override func viewWillAppear() {
super.viewWillAppear()
observe(statePublisher).store(in: &cancellables)
Expand Down
4 changes: 2 additions & 2 deletions ...lateGeneratorLibraryTests/__Snapshots__/UIFrameworkDefaultsTests/testDefaultsAppKit.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
▿ UIFramework
- framework: Framework.appKit
- viewControllerMethods: "override func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerMethodsForRootNode: "override func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewDidAppear() {\n super.viewDidAppear()\n receiver?.viewDidAppear()\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerMethods: "override func viewDidLoad() {\n super.viewDidLoad()\n update(with: initialState)\n}\n\noverride func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerMethodsForRootNode: "override func viewDidLoad() {\n super.viewDidLoad()\n update(with: initialState)\n}\n\noverride func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewDidAppear() {\n super.viewDidAppear()\n receiver?.viewDidAppear()\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerProperties: ""
4 changes: 2 additions & 2 deletions ...eGeneratorLibraryTests/__Snapshots__/UIFrameworkTests/testDecodingWithDefaults.AppKit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
▿ UIFramework
- framework: Framework.appKit
- viewControllerMethods: "override func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerMethodsForRootNode: "override func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewDidAppear() {\n super.viewDidAppear()\n receiver?.viewDidAppear()\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerMethods: "override func viewDidLoad() {\n super.viewDidLoad()\n update(with: initialState)\n}\n\noverride func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerMethodsForRootNode: "override func viewDidLoad() {\n super.viewDidLoad()\n update(with: initialState)\n}\n\noverride func viewWillAppear() {\n super.viewWillAppear()\n observe(statePublisher).store(in: &cancellables)\n}\n\noverride func viewDidAppear() {\n super.viewDidAppear()\n receiver?.viewDidAppear()\n}\n\noverride func viewWillDisappear() {\n super.viewWillDisappear()\n cancellables.removeAll()\n}"
- viewControllerProperties: ""