Merged
Conversation
tinder-emanharoutunian
requested a review
from tinder-cfuller
as a code owner
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Very cool! Excited to see this added to Nodes. 👍
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Looking great! Just needs a few more changes to tighten this up.
Sources/NodesTesting/DependencyProviderRegistrationBuilder.swift
Outdated
Show resolved
Hide resolved
tinder-emanharoutunian
changed the title
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Garric Nahapetian <31713341+tinder-garricnahapetian@users.noreply.github.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-emanharoutunian
force-pushed
the
test-helpers-target
branch
from
e9d5d7b to
f416aa6
Compare
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
tinder-cfuller
previously approved these changes
Feb 28, 2023
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Wow, what an excellent PR this has turned into. So glad we are able to get these DI test helpers into the Nodes repo! And I really like how the tests turned out!! They are so readable and concise. Great job ⭐
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a NodesTesting package along with tests in 'NodesTestingTests'.