Made a few methods private from ViewControllable#309
Merged
tinder-SamMarshall merged 11 commits intomainfrom Mar 28, 2023
Merged
Made a few methods private from ViewControllable#309tinder-SamMarshall merged 11 commits intomainfrom
tinder-SamMarshall merged 11 commits intomainfrom
Conversation
Contributor
Author
|
This is missing the relevant commit, one sec |
tinder-SamMarshall
changed the base branch from
main
to
feature/TDP-139956-removed-and-refactored
tinder-SamMarshall
changed the title
Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
Show resolved
Hide resolved
…/remove-view-controllable-methods # Conflicts: # Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
tinder-cfuller
previously approved these changes
Feb 26, 2023
Contributor
tinder-cfuller
left a comment
tinder-cfuller
left a comment
There was a problem hiding this comment.
Please update PR description to reflect the current changes. Thanks!
Base automatically changed from
feature/TDP-139956-removed-and-refactored
to
main
March 2, 2023 20:49
# Conflicts: # Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift # Tests/NodesTests/ViewControllable/ViewControllableTests.swift
tinder-SamMarshall
changed the title
Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
Outdated
Show resolved
Hide resolved
Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
Outdated
Show resolved
Hide resolved
Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
Outdated
Show resolved
Hide resolved
Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
Show resolved
Hide resolved
Sources/Nodes/ViewControllable/UIKit/UIViewController+ViewControllable.swift
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the following methods private from UIViewController+ViewControllable and removed them from the ViewControllable protocol:
willMove(toParent:)
didMove(toParent:)
addChild(:)
removeChild(:)