Add defaultKey support to PluginList#312
Merged
tinder-caiofonseca merged 7 commits intomainfrom Feb 7, 2023
Merged
Conversation
tinder-caiofonseca
force-pushed
the
defaultkey-support-pluginlist
branch
from
d024890 to
47ee15e
Compare
tinder-garricnahapetian
previously approved these changes
Jan 24, 2023
Contributor
|
Great work! Are there any more tests that should be added? |
Contributor
Author
I think we can. Let me check that! |
tinder-garricnahapetian
previously approved these changes
Jan 24, 2023
Contributor
tinder-garricnahapetian
left a comment
tinder-garricnahapetian
left a comment
There was a problem hiding this comment.
Thank you for adding another test!
tinder-caiofonseca
force-pushed
the
defaultkey-support-pluginlist
branch
from
cb9e3b2 to
1dd8a52
Compare
Co-authored-by: Garric Nahapetian <31713341+tinder-garricnahapetian@users.noreply.github.com>
tinder-garricnahapetian
previously approved these changes
Jan 25, 2023
tinder-caiofonseca
dismissed stale reviews from tinder-cfuller and tinder-garricnahapetian
via
d89b59d
tinder-caiofonseca
requested review from
tinder-cfuller and
tinder-garricnahapetian
tinder-garricnahapetian
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to PluginListWithDefault for overriding a defaultKey computed property for defining the KeyType value that maps to the default item in the Plugin List. This would then be utilized in
create(key: KeyType, state: StateType)to return the default item instead of an item from the collection. Thedefaultitem will also still be returned when an invalid key is provided to this method.