Fix extra space appearing in dependency protocol in Nodes Xcode template#319
Merged
tinder-matthewmourlam merged 1 commit intomainfrom Mar 20, 2023
Merged
Conversation
tinder-matthewmourlam
requested a review
from tinder-cfuller
as a code owner
tinder-cfuller
previously approved these changes
Mar 2, 2023
Tests/clear_snapshots
Outdated
| @@ -0,0 +1,2 @@ | |||
| cd "$(dirname "$0")" | |||
| rm -rf XcodeTemplateGeneratorLibraryTests/__Snapshots__/* No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Please move just this single rm line to the Makefile as a new recipe named delete-snapshots (The cd is not needed in this case). Then delete this clear_snapshots file. Thanks!
Contributor
There was a problem hiding this comment.
Actually the command will need to be rm -rf Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/*
Contributor
There was a problem hiding this comment.
The delete-snapshots recipe would look like this…
.PHONY: delete-snapshots
delete-snapshots:
rm -rf Tests/XcodeTemplateGeneratorLibraryTests/__Snapshots__/*
(note that the second line is indented with a tab character, not spaces, which is a Makefile requirement)
tinder-matthewmourlam
force-pushed
the
feature/remove-builder-dependency-newline
branch
from
df20de8 to
165a1b5
Compare
tinder-matthewmourlam
deleted the
feature/remove-builder-dependency-newline
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix extra space appearing in dependency protocol in Nodes Xcode template using
{{ '{' }}.Will want to consider using
trimBehaviorenvironment setting in stencil.