Rename "viewControllable" to "viewController"#321
Merged
tinder-caiofonseca merged 1 commit intomainfrom Mar 7, 2023
Merged
Conversation
| public func present(_ viewControllable: ViewControllable) { | ||
| rootViewController = viewControllable._asUIViewController() | ||
| /// - Parameter viewController: The ``ViewControllable`` instance to present. | ||
| public func present(_ viewController: ViewControllable) { |
Contributor
Author
There was a problem hiding this comment.
As we're not removing/renaming the viewControllable property in the flow, the attachment will still be using flow.viewControllable. Something like:
let flow: RootFlow = rootBuilder.build(withListener: context)
viewController.present(flow.viewControllable)
attach(starting: flow)
tinder-garricnahapetian
added
framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
viewControllablevariables, properties and arguments toviewControllerThis should include framework source code as well as the stencils.
And excluding only this specific
viewControllableproperty …https://github.com/TinderApp/Nodes/blob/main/Sources/XcodeTemplateGeneratorLibrary/Resources/Templates/Flow.stencil#L34