Compare imports as sorted array #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinder-garricnahapetian
requested a review
from tinder-cfuller
as a code owner
tinder-cfuller
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
imports(with:including:)returns aSet, the expected value created using array literal syntax in the expectation againstimportsis also aSet. Sets automatically de-dupe the contents of the array literal. That is why this test did not fail. By converting the actual value to anArray, the expected value also becomes anArrayand any duplicate values will not be removed.Arrays are ordered, therefore, we need to sort the imports to make the test predictable as
Setis unordered.The
uiFrameworkImportis dynamic so we need to add an additional handling for that case.