Fix #268 InvalidDependencyEdgesException now warns + reports distance 0

[tinder-maxwellelliott]

Summary

Fixes #268.

Root cause. Users who pass --targetType=Rule to generate-hashes end up with hash JSONs that only contain Rule entries — SourceFile and GeneratedFile rows are stripped at write time. When that JSON was fed back into get-impacted-targets --depsFile=... (which routes through executeWithDistances → computeAllDistances), an indirectly impacted Rule whose only changed dep was a filtered-out GeneratedFile triggered:

InvalidDependencyEdgesException("<label> was indirectly impacted, but has no impacted dependencies.")

and crashed the whole job. @agustinmista narrowed the cause to exactly this combination in the issue thread.

Fix. Both throw InvalidDependencyEdgesException(...) sites in CalculateImpactedTargetsInteractor.calculateDistance are replaced with a logger.w() that points at --targetType as the most likely cause, plus a return of TargetDistanceMetrics(0, 0). The indirectly impacted target still appears in the impacted-targets output rather than crashing the run.

Two code paths now warn-and-fallback instead of throw:

• The target has no entry in the dep-edges file at all.
• The target has dep-edges entries, but none of those deps are themselves in the impacted-labels map.

The previously-thrown @VisibleForTesting nested class InvalidDependencyEdgesException is no longer referenced, so it's removed along with its (now unused) com.google.common.annotations.VisibleForTesting import.

Tests. testInvalidEdgesRaises becomes testInvalidEdgesFallsBackToDistanceZero and now asserts both fallback paths return distance 0. The reproducer added in the first commit on this branch loses its @Ignore and is renamed to a regression test — it sets up the exact --targetType=Rule + GeneratedFile-in-depEdges-but-not-in-hashes scenario from the issue and asserts the call succeeds with //pkg:rule reported at distance 0.

Test plan

• bazel build //cli:cli-test-lib — clean.
• bazel test //cli:CalculateImpactedTargetsInteractorTest --cache_test_results=no → PASSED in 1.3s (all tests in the class, including the un-@Ignored reproducer and the rewritten testInvalidEdgesFallsBackToDistanceZero).
• Full unit-test sweep across all 12 kt_jvm_test targets → all 12 PASSED.

🤖 Generated with Claude Code