Skip to content

fix(is/object): array check #57

Closed
IKatsuba wants to merge 2 commits into from
Closed

fix(is/object): array check #57

IKatsuba wants to merge 2 commits into from

Conversation

@IKatsuba
Copy link

@IKatsuba IKatsuba commented Mar 14, 2020

BREAKING CHAGE: function isObject will now return false for arrays

IKatsuba added 2 commits March 14, 2020 17:46
@IKatsuba
fix(is/object): array check
82b9722 
BREAKING CHAGE: function `isObject` will now return `false` for arrays
@IKatsuba
fix(is/pathSet): broke after changes in isObject
309e6fe
@meskill
Copy link
Contributor

meskill commented Mar 16, 2020

I really think these changes will be non-intuitive for most users,
especially when analogs like lodash and ramda threat arrays as objects.

@IKatsuba
Copy link
Author

IKatsuba commented Mar 16, 2020

It is necessary to include cases with arrays in the documentation and tests. It confused me.

@IKatsuba IKatsuba closed this Mar 16, 2020
@IKatsuba IKatsuba deleted the fix-is-object branch March 16, 2020 07:57
@meskill
Copy link
Contributor

meskill commented Mar 16, 2020

yes, docs are not very detailed on that part,
feel free to open another pr with extended doc or create an issue for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IKatsuba @meskill