fix(invoke): resolve signalDone grace period race condition#258
Merged
Conversation
The SIGTERM kill triggers a `close` event with code 143 before the delayed settle(0) can run, causing a spurious rejection. Settle successfully before killing the process so the close event is a no-op. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a race condition in
runCommandStreamingwhere thesignalDonegrace period handler kills the subprocess with SIGTERM, which triggers thecloseevent with exit code 143 before the delayedsettle(0)can run. This causes a spurious rejection and the agent returns a generic error message instead of the successfully streamed result.Changes
settle(0)beforechild.kill('SIGTERM')so the promise resolves successfully and the subsequentcloseevent (code 143) is a no-opsetTimeout(() => settle(0), 2000)since settling now happens synchronously before the killTesting
settleguards onsettledflag, so thecloseevent after kill is safely ignoredChecklist
type(scope): description)