fix(ci): use PAT for release-plz so tag push triggers downstream workflows#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub does not let workflows triggered by GITHUB_TOKEN create new workflow runs (loop prevention). When release-plz pushed v1.3.0 with the default token, neither release.yml (binaries) nor docker.yml (Phala deploy) fired.
Switching to a fine-grained PAT (RELEASE_PLZ_TOKEN with
contents: write+pull-requests: write) bypasses this restriction.Changes
RELEASE_PLZ_TOKEN:actions/checkout@v4uses the PAT for git authGITHUB_TOKENCARGO_REGISTRY_TOKENreference unchangedAfter merging
The next release-plz tag push will trigger release.yml and docker.yml normally.
The existing v1.3.0 tag/release was created with GITHUB_TOKEN so downstream workflows didn't fire. To recover: delete the v1.3.0 tag + release, then re-run release-plz workflow manually. The team lead will handle this separately.