Conversation
Member
Author
|
May you review that, please @tdulcet? |
tdulcet
approved these changes
Oct 19, 2022
tdulcet
left a comment
tdulcet
left a comment
There was a problem hiding this comment.
LGTM.
Note that this is the type of error that the TypeScript Compiler is great at finding (see TinyWebEx/AddonTemplate#5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea what influence this typo has, but it is relevant for the implementation.
For whatever reason all parameter-replacements etc. have worked so far, however, that's why I'd like to have a second pair of eyes look over that.. kinda embarrassing... typo. 🙈
I mean, it's quite obvious that this may be what is meant here.
From how I understand it, this could have lead to problems, when the first HTML element would need to be replaced with
data-opt-i18n-keep-children, but this is not tested here./cc @tdulcet