Skip to content

Minor cnanges to 04-patch-extraction.ipynb#468

Merged
shaneahmed merged 7 commits intodevelopfrom
doc-04
Sep 14, 2022
Merged

Minor cnanges to 04-patch-extraction.ipynb#468
shaneahmed merged 7 commits intodevelopfrom
doc-04

Conversation

@DavidBAEpstein
Copy link
Collaborator

  • MAINT: fix spacing around backticked words.
  • DOC: Unhide hidden cells. Change "tail --line 1" to "tail -n 1" Incroporate changes implrmented by pre-commit hooks.
  • MAINT: Change "tail --line 1" to "tail -n 1". Correct spacing around backticked word.
  • MAINT: Rewrite text cell on restarting runtime, and replace non-ascii right-arrow by ampersand encoding. Apply pre-commit hooks.
  • DOC: unhide hidden cells
  • DOC: Rewrite text cell about restarting runtime under Colab. Replace non-ascii em-dash by " —". Pre-commit hooks.
  • DOC: Redo previous commit more carefully.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@DavidBAEpstein
Copy link
Collaborator Author

  1. Many of the changes I used to make for jnb-rst consistency are now made by @John-P's excellent pre-commit hooks, making my task shorter and simpler.
  2. At first I was confused by the differences in rendering, by different tools, of utf8 characters in text cells in jupyter notebooks: vim (in default mode) produces "\u2192", while jnb raw produces a right-arrow symbol.
  3. I have merged develop into doc-04.
  4. I think this small PR is ready to be merged.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #468 (c78b8c0) into develop (73f9d1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #468   +/-   ##
========================================
  Coverage    98.63%   98.63%           
========================================
  Files           62       62           
  Lines         5937     5937           
  Branches      1056     1056           
========================================
  Hits          5856     5856           
  Misses          69       69           
  Partials        12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed shaneahmed added the documentation Improvements or additions to documentation label Sep 12, 2022
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavidBAEpstein
Looks good.

@shaneahmed shaneahmed merged commit d047331 into develop Sep 14, 2022
@shaneahmed shaneahmed deleted the doc-04 branch September 14, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants