Merged
Conversation
- Improve tiatoolbox import using lazy import. Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Improve tiatoolbox import using lazy import. Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## develop #478 +/- ##
========================================
Coverage 99.64% 99.64%
========================================
Files 60 61 +1
Lines 5926 5927 +1
Branches 1056 1056
========================================
+ Hits 5905 5906 +1
Misses 9 9
Partials 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Fix path for imports Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for models Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for dsl Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for tiatoolbox.tools Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Run pip workflow only on relevant files Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for utils Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for wsicore Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for wsicore Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for registration Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for tileserver Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for tileserver Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
- Fix imports for models Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
shaneahmed
changed the title
John-P
reviewed
Sep 26, 2022
John-P
reviewed
Sep 26, 2022
John-P
approved these changes
Sep 26, 2022
Contributor
John-P
left a comment
John-P
left a comment
There was a problem hiding this comment.
Looks good, just a few minor comments.
- Run pip install workflow only on requirements file
…-only' into dev-improve-imports # Conflicts: # .github/workflows/pip-install.yml
- Update `numpy` requirements
- Import importlib.util instead of util
…-only' into dev-improve-imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import tiatoolboxby 10 times.